Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Range window-functions must support non-timestamp order-by expressions #216

Closed
mythrocks opened this issue Jun 18, 2020 · 3 comments
Closed

[FEA] Range window-functions must support non-timestamp order-by expressions #216

mythrocks opened this issue Jun 18, 2020 · 3 comments
Assignees
@wbo4958 @mythrocks
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P0 Must have for release

Comments

@mythrocks
Copy link
Collaborator

mythrocks commented Jun 18, 2020 •
edited
Loading

Window Functions in Rapids do not currently support non-timestamp ORDER BY expressions for RANGE based queries.
i.e. While the following query is supported:

SELECT MAX(score) OVER (PARTITION BY uid ORDER BY CAST(date AS TIMESTAMP) RANGE ...)

the following is not:

SELECT MAX(score) OVER (PARTITION BY uid ORDER BY date RANGE ...)

This will need rework in the CUDF primitives as well.
@mythrocks mythrocks added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jun 18, 2020
@mythrocks mythrocks self-assigned this Jun 18, 2020
@sameerz sameerz added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Aug 25, 2020
@revans2 revans2 mentioned this issue Oct 8, 2020
Merged
@tgravescs
Copy link
Collaborator

we are seeing an example of this that isn't falling back to the CPU for some reason filed #925

@sameerz sameerz added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Feb 18, 2021
@sameerz
Copy link
Collaborator

sameerz commented Apr 13, 2021

Depends on rapidsai/cudf#7866

@sameerz sameerz added P0 Must have for release and removed P1 Nice to have for release labels May 11, 2021
@sameerz
Copy link
Collaborator

sameerz commented May 18, 2021

Fixed by #2020

@sameerz sameerz closed this as completed May 18, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 027c34a (NVIDIA#216)
4902e88 
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
@pxLi pxLi mentioned this issue Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wbo4958 wbo4958

@mythrocks mythrocks

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P0 Must have for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wbo4958 @tgravescs @mythrocks @sameerz