Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency info #1095

Merged
merged 6 commits into from
Nov 18, 2020
Merged

Dependency info #1095

merged 6 commits into from
Nov 18, 2020

Commits on Nov 18, 2020

  1. Get cudf/spark dependency from the correct .m2 dir (NVIDIA#1062) 

    * Get cudf/spark dependency from the correct .m2 dir

'WORKSPACE' & 'M2DIR' vars are needed for shims to gen the correct cudf/spark dependency info in shims.

Below error in 'spark*-info.properties' is due to unset of 'WORKSPACE' & 'M2DIR':
    build/dependency-info.sh: line 30: /jenkins/printJarVersion.sh: No such file or directory
    build/dependency-info.sh: line 33: /jenkins/printJarVersion.sh: No such file or directory

To fix the error, we set the default values for them in 'build/dependency-info.sh':
    'M2DIR=$HOME/.m2/repository'
    'WORKSPACE=../..'

We also need to explicitly set the correct 'M2DIR' path, in case we change it by '-Dmaven.repo.local=$M2DIR'.
Already updated Jenkins scripts to set the correct 'M2DIR'.

Signed-off-by: Tim Liu <timl@nvidia.com>

* let mvn package fails in case the script 'build/dependency-info.sh' runs failure

* Stop mvn build if `build/build-info` fails

Signed-off-by: Tim Liu <timl@nvidia.com>

* Copyright 2020

Signed-off-by: Tim Liu <timl@nvidia.com>
    @NvTimLiu
    NvTimLiu committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    366f0e2 View commit details
    Browse the repository at this point in the history

  2. List the latest SNAPSHOT jar file in local maven repo 

    Signed-off-by: Tim Liu <timl@nvidia.com>
    @NvTimLiu
    NvTimLiu committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    c064e8f View commit details
    Browse the repository at this point in the history

  3. Get the path of 'dependency-info.sh', then set 'WORKSPACE' relative t… 

    …o it

Signed-off-by: Tim Liu <timl@nvidia.com>
    @NvTimLiu
    NvTimLiu committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    ebcf6e3 View commit details
    Browse the repository at this point in the history

  4. Only collect dependency info on Jenkins build

    @NvTimLiu
    NvTimLiu committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    6b8db1a View commit details
    Browse the repository at this point in the history

  5. Only collect timestamped dependency in Jenkins build 

    Collect snapshot dependency info only in Jenkins build,
In dev build, print 'SNAPSHOT' tag without time stamp, e.g.: cudf-0.17-SNAPSHOT.jar
    @NvTimLiu
    NvTimLiu committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    b8200a4 View commit details
    Browse the repository at this point in the history

  6. simplifying the dependencylogic

    @NvTimLiu
    NvTimLiu committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    48f8c93 View commit details
    Browse the repository at this point in the history