closeOnExcept -> withResources in MetaUtils #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
|
build |
abellina
changed the title
|
This is breaking related tests locally and in CI also. I had machine troubles so didn't run the tests beforehand until now. Please hold on reviewing until that is fixed. |
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
fix_leak_in_with_meta_utils
branch
from
d48a629
to
c734b14
Compare
abellina
changed the title
|
Ok sorry for the confusion, this one looks better now. Will trigger CI again. |
|
build |
revans2
approved these changes
Nov 13, 2020
jlowe
approved these changes
Nov 13, 2020
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
* closeOnExcept -> withResources in MetaUtils Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * getBatchFromMeta needs to add to the reference count Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* closeOnExcept -> withResources in MetaUtils Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * getBatchFromMeta needs to add to the reference count Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* closeOnExcept -> withResources in MetaUtils Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * getBatchFromMeta needs to add to the reference count Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1107) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
This fixes a leak in MetaUtils. It also replaces the use of
ArrayBufferwithArraysuch that the appropriate impl ofwithResourcesis picked.Thanks to @jlowe to help triage this.