closeOnExcept -> withResources in MetaUtils (NVIDIA#1107)

* closeOnExcept -> withResources in MetaUtils Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * getBatchFromMeta needs to add to the reference count Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
nartal1 · Nov 13, 2020 · 9787f36 · 9787f36
1 parent 706aef8
commit 9787f36
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala
@@ -221,10 +221,10 @@ object MetaUtils extends Arm {
    * @return table that must be closed by the caller
    */
   def getTableFromMeta(deviceBuffer: DeviceMemoryBuffer, meta: TableMeta): Table = {
-    closeOnExcept(new ArrayBuffer[ColumnVector](meta.columnMetasLength())) { columns =>
+    withResource(new Array[ColumnVector](meta.columnMetasLength())) { columns =>
       val columnMeta = new ColumnMeta
       (0 until meta.columnMetasLength).foreach { i =>
-        columns.append(makeCudfColumn(deviceBuffer, meta.columnMetas(columnMeta, i)))
+        columns(i) = makeCudfColumn(deviceBuffer, meta.columnMetas(columnMeta, i))
       }
       new Table(columns :_*)
     }