Add GpuSubstring handling to SortOrder canonicalization #1302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1269.
When canonicalizing a
SortOrder
to match the CPU, it turns out aGpuSubstring
operation can be a child of aSortOrder
. We weren't handling it, so it crashed. This adds canonicalization handling forGpuSubstring
.Verified this fixes the at-scale TPC-DS query 8 crash.