Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GpuSubstring handling to SortOrder canonicalization #1302

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Add GpuSubstring handling to SortOrder canonicalization #1302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea59b72
Add GpuSubstring handling to SortOrder canonicalization
jlowe Dec 7, 2020
37ff4a5
Merge branch 'branch-0.3' into sort-order-substring
jlowe Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,12 @@ object GpuOverrides {
g.qualifier,
g.explicitMetadata)
.canonicalized
case g: GpuSubstring =>
Substring(
canonicalizeToCpuForSortOrder(g.str),
canonicalizeToCpuForSortOrder(g.pos),
canonicalizeToCpuForSortOrder(g.len))
.canonicalized
case o: GpuExpression =>
throw new IllegalStateException(s"${o.getClass} is not expected to be a part of a SortOrder")
case other => other.canonicalized
Expand Down