Add an example RAPIDS-accelerated Hive UDF using native code #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
requested review from
GaryShen2008,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
This was referenced Jan 8, 2021
tgravescs
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
overall looks fine to me, but would be good to get someone more familiar with c++/cuda side to review.
Do we want to put the cuda version in the name of the jar or library?
Do we want to add README here to explain using docker file and use profile udf-native-examples or is that in the other PR?
|
oops never mind, you already said docs later |
The native code statically links the CUDA runtime, so we don't need to put the CUDA version in the jar name. |
sameerz
added
the
task
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…1472) Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…1472) Signed-off-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1472) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1353
This adds an example of a Hive UDF that leverages native CUDA code to implement a RAPIDS-accelerated version. A Dockerfile is provided to show how to setup an environment for compiling the native UDF code against libcudf and the version of cub, thrust, and libcudacxx used by libcudf.
An integration test is provided, but the user must supply the
--rapids_udf_example_nativeflag in order to enable the test, as most nightly builds will not bother to perform the extra steps necessary to build the native code required by the new example.Documentation that covers this native example and implementing RAPIDS-acclerated Hive UDFs in general will be covered in #1354.