Avoid unnecessary Table instances after contiguous split #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
added
performance
abellina
reviewed
Jan 27, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/CopyCompressionCodec.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/RapidsShuffleInternalManagerBase.scala
Show resolved
Hide resolved
revans2
reviewed
Jan 27, 2021
sql-plugin/src/main/java/com/nvidia/spark/rapids/GpuCompressedColumnVector.java
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/CopyCompressionCodec.scala
Show resolved
Hide resolved
sql-plugin/src/main/java/com/nvidia/spark/rapids/GpuColumnVectorFromBuffer.java
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsDeviceMemoryStore.scala
Show resolved
Hide resolved
sql-plugin/src/main/java/com/nvidia/spark/rapids/GpuCompressedColumnVector.java
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/java/com/nvidia/spark/rapids/GpuPackedTableColumn.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
abellina
reviewed
Feb 4, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsDeviceMemoryStore.scala
Show resolved
Hide resolved
abellina
approved these changes
Feb 4, 2021
revans2
approved these changes
Feb 5, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Avoid unnecessary Table instances after contiguous split Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Address review comments Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove ColumnMeta Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove extra license file Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Avoid unnecessary Table instances after contiguous split Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Address review comments Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove ColumnMeta Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove extra license file Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on rapidsai/cudf#7127.
This change avoids manifesting cudf
TableandColumnVectorinstances after a partition via contiguous split, as these buffers are likely to be shipped off to other nodes over the network rather than used as a columnar batch input in the same process. Instantiating all of the tables and column objects for many splits can take a significant amount of time per task.This also changes the table metadata used for UCX shuffle to use the new libcudf opaque metadata generated by the
contiguous_splitandpackmethods, eliminating a lot ofColumnMetaflatbuffer classes.