Update JNI for contiguous_split packed results [skip ci] #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
added
2 - In Progress
revans2
approved these changes
Jan 13, 2021
revans2
approved these changes
Feb 2, 2021
|
Any reason this is still a draft? We are entering code freeze so it would be good to get it merged ASAP if ready. |
Yes, it requires #7096 to be merged first. After that dependency goes in this should quickly follow. |
abellina
approved these changes
Feb 3, 2021
jlowe
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires the libcudf changes in #7096, fixing the Java bindings to
contiguous_splitthat are broken by that change.This also adds the ability to create a
ContiguousTableinstance without manifesting aTableinstance and allColumnVectorinstances underneath it which should prove useful during Spark's shuffle.