Call GpuDeviceManager.shutdown when the executor plugin is shutting down #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
jlowe
reviewed
Feb 11, 2021
jlowe
approved these changes
Feb 11, 2021
gerashegalov
approved these changes
Feb 11, 2021
| @@ -210,6 +210,7 @@ class RapidsExecutorPlugin extends ExecutorPlugin with Logging { | |||
| override def shutdown(): Unit = { | |||
| GpuSemaphore.shutdown() | |||
| PythonWorkerSemaphore.shutdown() | |||
| GpuDeviceManager.shutdown() | |||
There was a problem hiding this comment.
I wonder if we should make these classes (Auto)Closable? then we could use hadoop's IOUtils
to IOUtils.cleanup(null, GpuSemaphore, PythonWorkerSemaphore, GpuDeviceManager)
There was a problem hiding this comment.
So we actually have safeClose already. safeClose will call .close() on every member of the collection, but then will throw at the end if there was a problem closing any member. I can certainly do this as part of this PR, the classes we care about are exactly these three.
There was a problem hiding this comment.
Ok lets skip it for now, we can follow up with a cleanup PR.
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…own (NVIDIA#1713) * Call GpuDeviceManager.shutdown when the executor plugin is shutting down Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Update copyright
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…own (NVIDIA#1713) * Call GpuDeviceManager.shutdown when the executor plugin is shutting down Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Update copyright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
@gerashegalov noticed the following host memory leak in unit tests:
This was because the
RapidsHostMemoryStore(and its pool) were not being shutdown. The included here removes the leak from the tests.