Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call GpuDeviceManager.shutdown when the executor plugin is shutting down #1713

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Call GpuDeviceManager.shutdown when the executor plugin is shutting down #1713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0749de3
Call GpuDeviceManager.shutdown when the executor plugin is shutting down
abellina Feb 11, 2021
c50bd36
Update copyright
abellina Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql-plugin/src/main/scala/com/nvidia/spark/rapids/Plugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019-2020, NVIDIA CORPORATION.
* Copyright (c) 2019-2021, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -210,6 +210,7 @@ class RapidsExecutorPlugin extends ExecutorPlugin with Logging {
override def shutdown(): Unit = {
jlowe marked this conversation as resolved.
Show resolved Hide resolved
GpuSemaphore.shutdown()
PythonWorkerSemaphore.shutdown()
GpuDeviceManager.shutdown()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make these classes (Auto)Closable? then we could use hadoop's IOUtils
to IOUtils.cleanup(null, GpuSemaphore, PythonWorkerSemaphore, GpuDeviceManager)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we actually have safeClose already. safeClose will call .close() on every member of the collection, but then will throw at the end if there was a problem closing any member. I can certainly do this as part of this PR, the classes we care about are exactly these three.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree not necessary for this PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lets skip it for now, we can follow up with a cleanup PR.

}
}

Expand Down