Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge conflict with branch-0.4 #1937

Merged
merged 6 commits into from
Mar 16, 2021
Merged

Fix merge conflict with branch-0.4 #1937

merged 6 commits into from
Mar 16, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 15, 2021

Fixes the merge conflict flagged by #1936. All the conflicts were with documentation or doc strings in code. All conflicts were dropped in favor of the existing branch-0.5 version except for download.md where the change needed to be migrated to the new layout in that document.

NOTE: This needs to be committed with a merge commit, not squashed!

@jlowe jlowe added the build Related to CI / CD or cleanly building label Mar 15, 2021
@jlowe jlowe self-assigned this Mar 15, 2021
@jlowe
Copy link
Member Author

jlowe commented Mar 15, 2021

build

revans2
revans2 previously approved these changes Mar 15, 2021
NvTimLiu and others added 3 commits March 16, 2021 15:16
* Change cudf dependency to 0.18.1

Signed-off-by: Tim Liu <timl@nvidia.com>

* Revert RapidsConf.scala, will update it in another PR along with the docs
* First step restrict hash shuffle support

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>

* Pulled in join tests

* Added in exct partitioning tests

* all the things

* Decimal works

* Cleanup

* Addressed review comments

* Fix failing tests because of spark changes

* Add back in failing test
Signed-off-by: Peixin Li <pxli@nyu.edu>
@pxLi
Copy link
Collaborator

pxLi commented Mar 16, 2021

#1936 got more commits merged,
can you help fix the conflict within this PR? I can start a new one if you are not available, thanks!

@jlowe
Copy link
Member Author

jlowe commented Mar 16, 2021

Yes, I'll update this with the new commits

@revans2
Copy link
Collaborator

revans2 commented Mar 16, 2021

build

1 similar comment
@jlowe
Copy link
Member Author

jlowe commented Mar 16, 2021

build

@jlowe jlowe merged commit b770323 into NVIDIA:branch-0.5 Mar 16, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Fix merge conflict with branch-0.4
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Fix merge conflict with branch-0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants