Remove the term whitelist #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #363 |
|
build |
nartal1
previously approved these changes
Jul 17, 2020
revans2
reviewed
Jul 17, 2020
| @@ -1,3 +1,4 @@ | |||
| /enable | |||
There was a problem hiding this comment.
I think this is a type that is causing the build to fail
There was a problem hiding this comment.
Apologies, I realized after the build failed that I ran with -DskipTests on a non-GPU machine. I reran with mvn clean verify -Dcuda.version=cuda10-2 and the tests passed. I will try rerunning the premerge tests.
|
build |
revans2
approved these changes
Jul 17, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Removing the term whitelist * fix typo in hash_aggregate_test.py
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Removing the term whitelist * fix typo in hash_aggregate_test.py
pxLi
pushed a commit
to pxLi/spark-rapids
that referenced
this pull request
May 12, 2022
* Update CI/CD requirements and tests * Fix main ci (NVIDIA#377) * Fix build doc process (NVIDIA#387) * Fix app testing pt model validator * Update tests * Fix format issues * Fix integration tests * Update premerge.yml * Fix format * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made.
Removing the term whitelist per https://tools.ietf.org/id/draft-knodel-terminology-00.html
added.
No new tests, ran
mvn clean verify -DskipTeststo verify