Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the term whitelist #387

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Remove the term whitelist #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a669b22
Removing the term whitelist
sameerz Jul 17, 2020
9bbfebf
fix typo in hash_aggregate_test.py
sameerz Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api_validation/src/main/scala/com/nvidia/spark/rapids/api/ApiValidation.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ object ApiValidation extends Logging {
})
}

val whiteListExecs = List (
val enabledExecs = List (
"[org.apache.spark.sql.execution.joins.SortMergeJoinExec]",
"[org.apache.spark.sql.execution.aggregate.HashAggregateExec]"
)
Expand All @@ -73,8 +73,8 @@ object ApiValidation extends Logging {
// Get SparkExecs argNames and types
val sparkTypes = stringToTypeTag(e)

// Proceed only if the Exec is not whitelisted
if (!whiteListExecs.contains(sparkTypes.toString().replace("TypeTag", ""))) {
// Proceed only if the Exec is not enabled
if (!enabledExecs.contains(sparkTypes.toString().replace("TypeTag", ""))) {
val sparkParameters = getCaseClassAccessors(sparkTypes).map(m => m.name -> m.info)

// Get GpuExecs argNames and Types.
Expand Down
2 changes: 1 addition & 1 deletion integration_tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ The marks you care about are all in marks.py
* `ignore_order` tells the asserts to sort the resulting data because the tests may not produce the results in the same order
* `incompat` tells the tests to enable incompat operators. It does not enable approximate comparisons for floating point though.
* `approximate_float` tells the tests to compare floating point values (including double) and allow for an error. This follows `pytest.approx` and will also take `rel` and `abs` args.
* `allow_non_gpu` tells the tests that not everything in the query will run on the GPU. You can tell it to allow all CPU fallback by `@allow_non_gpu(any=True)` you can also pass in class names that are white listed for CPU operation.
* `allow_non_gpu` tells the tests that not everything in the query will run on the GPU. You can tell it to allow all CPU fallback by `@allow_non_gpu(any=True)` you can also pass in class names that are enabled for CPU operation.

### `spark_session.py`

Expand Down
2 changes: 1 addition & 1 deletion integration_tests/src/main/python/hash_aggregate_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def get_params(init_list, marked_params=[]):
"""
A method to build the test inputs along with their passed in markers to allow testing
specific params with their relevant markers. Right now it is used to parametrize _confs with
allow_non_gpu which allows some operators to be whitelisted.
allow_non_gpu which allows some operators to be enabled.
However, this can be used with any list of params to the test.
:arg init_list list of param values to be tested
:arg marked_params A list of tuples of (params, list of pytest markers)
Expand Down