Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unused method with its outdated comment #4212

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Remove an unused method with its outdated comment #4212

merged 1 commit into from
Nov 24, 2021

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Nov 24, 2021 •
edited
Loading

Minor cleanup in ShimLoader.scala

  • unused method setSparkShimProviderClass that used to power the shim override option
  • unnecessary self-reference in newExplainPlan

Fixes #4213

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov
Remove an unused method with its outdated comment
91c2b6a 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov self-assigned this Nov 24, 2021
@gerashegalov gerashegalov added the task Work required that improves the product but is not user facing label Nov 24, 2021
@gerashegalov gerashegalov added this to the Nov 15 - Nov 26 milestone Nov 24, 2021
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov linked an issue Nov 24, 2021 that may be closed by this pull request
[BUG] unused method with a misleading outdated comment in ShimLoader #4213
Closed
@gerashegalov gerashegalov merged commit 18875c8 into NVIDIA:branch-22.02 Nov 24, 2021
@gerashegalov gerashegalov deleted the shimLoaderCleanup branch November 24, 2021 22:17
@gerashegalov gerashegalov mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@tgravescs tgravescs Awaiting requested review from tgravescs

Assignees

@gerashegalov gerashegalov

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
Nov 15 - Nov 26
Development

Successfully merging this pull request may close these issues.

[BUG] unused method with a misleading outdated comment in ShimLoader
2 participants
@gerashegalov @jlowe