Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unused method with its outdated comment #4212

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Remove an unused method with its outdated comment #4212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions sql-plugin/src/main/scala/com/nvidia/spark/rapids/ShimLoader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,15 +355,6 @@ object ShimLoader extends Logging {
SPARK_BUILD_DATE
)

// TODO broken right now, check if this can be supported with parallel worlds
// it implies the prerequisite of having such a class in the conventional root jar entry
// - or the necessity of an additional parameter for specifying the shim subdirectory
// - or enforcing the convention the class file parent directory is the shimId that is also
// a top entry e.g. /spark301/com/nvidia/test/shim/spark301/Spark301Shims.class
def setSparkShimProviderClass(classname: String): Unit = {
shimProviderClass = classname
}

def loadClass(className: String): Class[_] = {
val loader = getShimClassLoader()
logDebug(s"Loading $className using $loader with the parent loader ${loader.getParent}")
Expand Down Expand Up @@ -428,6 +419,6 @@ object ShimLoader extends Logging {
}

def newExplainPlan(): ExplainPlanBase = {
ShimLoader.newInstanceOf[ExplainPlanBase]("com.nvidia.spark.rapids.ExplainPlanImpl")
newInstanceOf[ExplainPlanBase]("com.nvidia.spark.rapids.ExplainPlanImpl")
}
}