Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off noscaladoc rule until codebase is fixed #464

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Jul 29, 2020

The NoScalaDoc rule was turned on by #449 but this was tested without #450 applied. When they both went in with separate CI checks, the build broke. We need the fix from #461 but until we get the needed signoff this will disable the check to allow CI and builds to pass.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the build Related to CI / CD or cleanly building label Jul 29, 2020
@jlowe jlowe added this to the Jul 20 - Jul 31 milestone Jul 29, 2020
@jlowe jlowe self-assigned this Jul 29, 2020
@jlowe
Copy link
Member Author

jlowe commented Jul 29, 2020

build

@abellina abellina merged commit 76a1d4d into NVIDIA:branch-0.2 Jul 29, 2020
@jlowe jlowe mentioned this pull request Jul 30, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe deleted the disable-noscaladoc branch September 10, 2021 15:30
pxLi pushed a commit to pxLi/spark-rapids that referenced this pull request May 12, 2022
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
[auto-merge] bot-auto-merge-branch-22.08 to branch-22.10 [skip ci] [bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants