Initial support for reading decimal types from JSON and CSV #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
commented
Feb 18, 2022
| * [spark.rapids.sql.csv.read.float.enabled](configs.md#sql.csv.read.float.enabled) | ||
| * [spark.rapids.sql.csv.read.integer.enabled](configs.md#sql.csv.read.integer.enabled) | ||
| * [spark.rapids.sql.csv.read.long.enabled](configs.md#sql.csv.read.long.enabled) | ||
| * [spark.rapids.sql.csv.read.short.enabled](configs.md#sql.csv.read.short.enabled) | ||
| * [spark.rapids.sql.csvTimestamps.enabled](configs.md#sql.csvTimestamps.enabled) |
There was a problem hiding this comment.
These changes are not specific to this PR and could be PR'd separately
revans2
reviewed
Feb 18, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/catalyst/json/rapids/GpuJsonScan.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/catalyst/json/rapids/GpuJsonScan.scala
Outdated
Show resolved
Hide resolved
andygrove
changed the title
|
build |
This was
linked to
issues
Feb 22, 2022
This was referenced Feb 23, 2022
|
@revans2 Could I get another review on this one? There were changes after your last approval, to reduce the amount of regexp in use. |
revans2
approved these changes
Mar 7, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/catalyst/json/rapids/GpuJsonScan.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/catalyst/json/rapids/GpuJsonScan.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Closes #4824 and #4615 and #4646
The main change in this PR is adding support for reading decimal values from CSV and JSON by reading them as strings and then casting them to decimal.
There is also a fix for a bug in handling invalid JSON floating-point values such as
.1and1.which was discovered during this work.There are also some updates to the compatibility guide related to previous JSON and CSV PRs. I can PR those docs changes separately if that is preferred.