Support WindowExec partitioning by Decimal 128 on the GPU #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navin Kumar <navink@nvidia.com>
revans2
previously approved these changes
Feb 22, 2022
|
build |
mythrocks
previously approved these changes
Feb 22, 2022
|
build |
|
build |
revans2
approved these changes
Feb 22, 2022
jlowe
reviewed
Feb 22, 2022
jlowe
approved these changes
Feb 22, 2022
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4712.
This updates the WindowExec type check to allow Decimal 128 as a valid type in the partitionSpec. Also, integration tests for window functions have been updated to support higher precision decimals to test Decimal 128 support.
Signed-off-by: Navin Kumar navink@nvidia.com