Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WindowExec partitioning by Decimal 128 on the GPU #4836

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Support WindowExec partitioning by Decimal 128 on the GPU #4836

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fab27e0
Support Decimal 128 as an input type into the partition spec
NVnavkumar Feb 18, 2022
f1f2012
Updated doc
NVnavkumar Feb 22, 2022
2a47b16
remove this particular test so that it can pass CI
NVnavkumar Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions integration_tests/src/main/python/window_function_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,16 @@
('b', LongGen(nullable=True))]

part_and_order_gens = [long_gen, DoubleGen(no_nans=True, special_cases=[]),
string_gen, boolean_gen, timestamp_gen, DecimalGen(precision=18, scale=1)]
string_gen, boolean_gen, timestamp_gen, DecimalGen(precision=18, scale=1),
DecimalGen(precision=38, scale=1)]

running_part_and_order_gens = [long_gen, DoubleGen(no_nans=True, special_cases=[]),
string_gen, byte_gen, timestamp_gen, DecimalGen(precision=18, scale=1)]
string_gen, byte_gen, timestamp_gen, DecimalGen(precision=18, scale=1),
DecimalGen(precision=38, scale=1)]

lead_lag_data_gens = [long_gen, DoubleGen(no_nans=True, special_cases=[]),
boolean_gen, timestamp_gen, string_gen, DecimalGen(precision=18, scale=3),
DecimalGen(38, 4),
DecimalGen(precision=38, scale=4),
StructGen(children=[
['child_int', IntegerGen()],
['child_time', DateGen()],
Expand Down Expand Up @@ -994,7 +996,7 @@ def do_it(spark):

@ignore_order(local=True)
# single-level structs (no nested structs) are now supported by the plugin
@pytest.mark.parametrize('part_gen', [StructGen([["a", long_gen]])], ids=meta_idfn('partBy:'))
@pytest.mark.parametrize('part_gen', [StructGen([["a", long_gen]]), StructGen([["a", decimal_gen_36_5]])], ids=meta_idfn('partBy:'))
def test_nested_part_struct(part_gen):
data_gen = [
('a', RepeatSeqGen(part_gen, length=20)),
Expand Down
4 changes: 2 additions & 2 deletions sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3769,8 +3769,8 @@ object GpuOverrides extends Logging {
TypeSig.all,
Map("partitionSpec" ->
InputCheck(
TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL_64 +
TypeSig.STRUCT.nested(TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL_64),
TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL_128 +
TypeSig.STRUCT.nested(TypeSig.commonCudfTypes + TypeSig.NULL + TypeSig.DECIMAL_128),
TypeSig.all))),
(windowOp, conf, p, r) =>
new GpuWindowExecMeta(windowOp, conf, p, r)
Expand Down