Add test cases for casting string to date in ANSI mode #5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
jlowe
reviewed
May 11, 2022
| @@ -65,6 +65,22 @@ def test_cast_string_date_valid_format(): | |||
| lambda spark : unary_op_df(spark, StringGen('[0-9]{1,4}-[0-9]{1,2}-[0-9]{1,2}')).select(f.col('a').cast(DateType())), | |||
| conf = {'spark.rapids.sql.hasExtendedYearValues': 'false'}) | |||
|
|
|||
| @pytest.mark.skipif(is_before_spark_320(), reason="ansi cast(string as date) throws exception only in 3.2.0+") | |||
There was a problem hiding this comment.
Do we need a test to verify we're doing the right thing on Spark versions < 3.2.0, i.e.: either producing a matching result or falling back to the CPU?
|
build |
jlowe
approved these changes
May 12, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1557
Add test cases for casting string to date in ANSI mode
Already supported in #3396, this PR just adds test cases
Signed-off-by: Chong Gao res_life@163.com