Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for casting string to date in ANSI mode #5459

Merged
merged 2 commits into from
May 13, 2022
Merged

Add test cases for casting string to date in ANSI mode #5459

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cd96d8
Add test cases for casting string to date in ANSI mode
May 11, 2022
79f102c
Update test cases
May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions integration_tests/src/main/python/cast_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,22 @@ def test_cast_string_date_valid_format():
lambda spark : unary_op_df(spark, StringGen('[0-9]{1,4}-[0-9]{1,2}-[0-9]{1,2}')).select(f.col('a').cast(DateType())),
conf = {'spark.rapids.sql.hasExtendedYearValues': 'false'})

@pytest.mark.skipif(is_before_spark_320(), reason="ansi cast(string as date) throws exception only in 3.2.0+")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test to verify we're doing the right thing on Spark versions < 3.2.0, i.e.: either producing a matching result or falling back to the CPU?

@pytest.mark.parametrize('invalid', ['200', '1970A', '1970 A', '1970T', '1970 T', '1970-01T', '1970-01 A',
'1970-01-01A', # 1970-01-01T is OK, 1970-01-01A is NOK
'2022-02-29', # nonexistent day
'200-1-1',
'2001-13-1', # nonexistent day
'2001-1-32', # nonexistent day
'2001-1-32' # nonexistent day
])
def test_cast_string_date_invalid_ansi(invalid):
jlowe marked this conversation as resolved.
Show resolved Hide resolved
assert_gpu_and_cpu_error(
lambda spark: spark.createDataFrame([(invalid,)], "a string").select(f.col('a').cast(DateType())).collect(),
conf={'spark.rapids.sql.hasExtendedYearValues': 'false',
'spark.sql.ansi.enabled': 'true'},
error_message="DateTimeException")

def test_cast_string_ts_valid_format():
# In Spark 3.2.0+ the valid format changed, and we cannot support all of the format.
# This provides values that are valid in all of those formats.
Expand Down