Move ShimServiceProvider file re-init/truncate #5599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR closes 5596 by moving truncate close to when shim service file concatentation is about to generate a new list. T The empty file for ShimServiceProvider created during init-properties is not populated via concat in the conventional jar path, later overwriting the original file from the aggregator jar. it's also bad practice to have side effects while still initializing properties. This PR corrects these issues. Signed-off-by: Gera Shegalov <gera@apache.org>
jlowe
reviewed
May 23, 2022
Signed-off-by: Gera Shegalov <gera@apache.org>
|
build |
jlowe
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #5596 by moving truncate close to when shim service file
concatentation is about to generate a new list.
The empty file for ShimServiceProvider created during init-properties is not populated via
concat in the conventional jar path, later overwriting the original file
from the aggregator jar. it's also bad practice to have side effects
while still initializing properties. This PR corrects these issues.
Signed-off-by: Gera Shegalov gera@apache.org