Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ShimServiceProvider file re-init/truncate #5599

Merged
merged 2 commits into from
May 24, 2022
Merged

Move ShimServiceProvider file re-init/truncate #5599

merged 2 commits into from
May 24, 2022

Commits on May 23, 2022

  1. Move ShimServiceProvider file re-init/truncate 

    This PR closes 5596 by moving truncate close to when shim service file
concatentation is about to generate a new list. T

The empty file for ShimServiceProvider created during init-properties is not populated via
concat in the conventional jar path, later overwriting the original file
from the aggregator jar. it's also bad practice to have side effects
while still initializing properties. This PR corrects these issues.

Signed-off-by: Gera Shegalov <gera@apache.org>
    @gerashegalov
    gerashegalov committed May 23, 2022
    Configuration menu
    Copy the full SHA
    452f42f View commit details
    Browse the repository at this point in the history

  2. delete debug log 

    Signed-off-by: Gera Shegalov <gera@apache.org>
    @gerashegalov
    gerashegalov committed May 23, 2022
    Configuration menu
    Copy the full SHA
    0f40c1d View commit details
    Browse the repository at this point in the history