-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add a progress bar in Qualification tool when it is running #5988
Conversation
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
build |
1 similar comment
build |
tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/Qualification.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/ui/ConsoleProgressBar.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Some of the thoughts to mention:
@viadea and @mattahrens are you guys fine with the behavior of the PB as implemented here? |
build |
The failures in the CI seem to be unrelated to the changes. |
I'm fine with the proposed logic and output for the progress bar 👍 |
I am fine with this bar too. thanks! |
Thank you @viadea , @mattahrens and @nartal1 for the feedback! |
build |
The CI failures caused by |
build |
1 similar comment
build |
The CI is now fixed. |
tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/Qualification.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/Qualification.scala
Outdated
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/ui/ConsoleProgressBar.scala
Outdated
Show resolved
Hide resolved
I made some changes to the consoleProgressBar.
|
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
build |
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
fixes #5911
New Behavior
Changes
ConsoleProgressBar
similar toorg.apache.spark.ui.ConsoleProgressBar