Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable zstd integration tests for parquet and orc [databricks] #5991

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

jbrennan333
Copy link
Collaborator

Signed-off-by: Jim Brennan jimb@nvidia.com

This is a followup to #5898 and #5916.
Now that cuDF PR 11226 has been merged, we no longer need to specify LIBCUDF_NVCOMP_POLICY=ALWAYS to use zstd.

This also updates to include orc_test.py, since cuDF supports zstd for both parquet and orc.

Closes #5580

Signed-off-by: Jim Brennan <jimb@nvidia.com>
@sameerz sameerz added the test Only impacts tests label Jul 12, 2022
@jbrennan333
Copy link
Collaborator Author

build

Copy link
Collaborator

@razajafri razajafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the CI include databricks?

jlowe
jlowe previously approved these changes Jul 12, 2022
@jbrennan333
Copy link
Collaborator Author

@razajafri not a bad idea. I will add databricks.

@jbrennan333 jbrennan333 changed the title Enable zstd integration tests for parquet and orc Enable zstd integration tests for parquet and orc [databricks] Jul 12, 2022
@jbrennan333
Copy link
Collaborator Author

build

@jbrennan333
Copy link
Collaborator Author

I'm seeing what look like a lot of unrelated failures in the pre-merge integration tests.

[2022-07-12T21:11:05.301Z] [gw0] [ 48%] FAILED ../../src/main/python/conditionals_test.py::test_case_when[Map(Short(not_null),Struct(['child0', Byte],['child1', Double]))] 
[2022-07-12T21:11:05.558Z] ../../src/main/python/conditionals_test.py::test_if_else[Short] 
[2022-07-12T21:11:05.558Z] [gw0] [ 48%] FAILED ../../src/main/python/conditionals_test.py::test_if_else[Short] 
[2022-07-12T21:11:05.558Z] ../../src/main/python/conditionals_test.py::test_if_else[Double] 
[2022-07-12T21:11:05.559Z] [gw0] [ 49%] FAILED ../../src/main/python/conditionals_test.py::test_if_else[Double] 
[2022-07-12T21:11:05.816Z] ../../src/main/python/conditionals_test.py::test_if_else[Decimal(7,3)] 
[2022-07-12T21:11:05.816Z] [gw1] [ 49%] PASSED ../../src/main/python/window_function_test.py::test_window_running[Decimal(7,3)-Long-1g][IGNORE_ORDER({'local': True})] 

@jlowe
Copy link
Member

jlowe commented Jul 12, 2022

I'm seeing what look like a lot of unrelated failures in the pre-merge integration tests.

Known issues being worked on, see #5979

@jbrennan333
Copy link
Collaborator Author

@jlowe thanks for the confirmation. I thought it might be that.

razajafri
razajafri previously approved these changes Jul 12, 2022
@jbrennan333
Copy link
Collaborator Author

build

2 similar comments
@jbrennan333
Copy link
Collaborator Author

build

@pxLi
Copy link
Collaborator

pxLi commented Jul 14, 2022

build

@jbrennan333 jbrennan333 dismissed stale reviews from razajafri and jlowe via 560d643 July 14, 2022 14:09
@jbrennan333
Copy link
Collaborator Author

Merged up to resolve conflicts.

@jbrennan333
Copy link
Collaborator Author

build

@jbrennan333 jbrennan333 merged commit f55329b into NVIDIA:branch-22.08 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Enable zstd integration tests for parquet and orc
5 participants