Qualification tool: Parse expressions in Aggregates and Sort execs. #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
reviewed
Jul 21, 2022
tools/src/main/scala/com/nvidia/spark/rapids/tool/planparser/SQLPlanParser.scala
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/planparser/SQLPlanParser.scala
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/planparser/SQLPlanParser.scala
Show resolved
Hide resolved
tools/src/test/scala/com/nvidia/spark/rapids/tool/planparser/SqlPlanParserSuite.scala
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/planparser/SQLPlanParser.scala
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
approved these changes
Jul 22, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to #5617
This PR adds parsing support for AggregateExecs(SortAggregate, HashAggregate and ObjectHashAggregate) and SortExec.
The format for Aggregates are same in the eventlog so a single parser is required.
Current tests would verify the parsing function for Aggregates. Added test for parsing function within SortExec.
Verified by running this on NDS eventlogs to make sure we are not missing anything while parsing these Execs.