Tag GpuWindow child expressions for GPU execution
#6057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#5984. Currently, `UnixTimeExprMeta` postpones part of the initialization of its state to `tagExprForGpu()`. This leads to situations where an incompletely initialized `UnixTimeExprMeta` object is exercised at runtime, such as in NVIDIA#5984. This change moves the initialization to the constructor, leaving `tagExprForGpu()` to deal only with tagging. Signed-off-by: MithunR <mythrocks@gmail.com>
|
(Tentative fix. Still considering other options to sort out #5984.) |
jlowe
reviewed
Jul 22, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
|
I'll post a better solution to this shortly. |
This reverts commit 0101417. This is the wrong solution. It does not protect against a different, unsupported time-format used in a window function.
This change tags the child expressions of a GpuWindowExecMeta, to ensure that all dependency expressions initialized correctly. Certain child expressions might not be completely initialized even after `GpuOverrides#wrapExpr()` has been called. For instance, `UnixTimeExprMeta` postpones some of its initialization until `tagExprForGpu()` is called. By declaring `windowExpressions`, `partitionSpec`, `orderSpec`, etc. as `childExprs` of `GpuWindowExecMeta`, one guarantees that the `GpuOverrides` infrastructure will tag them for GPU execution. Signed-off-by: MithunR <mythrocks@gmail.com>
mythrocks
changed the title
GpuWindow child expressions for GPU execution
The solution has been modified to have |
jlowe
approved these changes
Jul 26, 2022
|
build |
|
Thank you for reviewing, @jlowe. I've merged this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5984.
This change tags the child expressions of a GpuWindowExecMeta, to ensure
that all dependency expressions initialized correctly.
Certain child expressions might not be completely initialized even after
GpuOverrides#wrapExpr()has been called. For instance,UnixTimeExprMetapostpones some of its initialization until
tagExprForGpu()is called.By declaring
windowExpressions,partitionSpec,orderSpec, etc. aschildExprsofGpuWindowExecMeta, one guarantees that theGpuOverridesinfrastructure will tag them for GPU execution.Signed-off-by: MithunR mythrocks@gmail.com