Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag GpuWindow child expressions for GPU execution #6057

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Tag GpuWindow child expressions for GPU execution #6057

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0101417
Move initialization of UnixTimeExprMeta to constructor:
mythrocks Jul 22, 2022
668c24e
Revert "Move initialization of UnixTimeExprMeta to constructor:"
mythrocks Jul 25, 2022
fe50908
Merge remote-tracking branch 'origin/branch-22.08' into tentative-fix…
mythrocks Jul 25, 2022
935a4b3
Tag GpuWindow child expressions for GPU execution:
mythrocks Jul 25, 2022
aeb119c
Updated Javadoc.
mythrocks Jul 25, 2022
aad2059
Added repro case to window_function_test.py.
mythrocks Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions sql-plugin/src/main/scala/org/apache/spark/sql/rapids/datetimeExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,19 +374,26 @@ abstract class UnixTimeExprMeta[A <: BinaryExpression with TimeZoneAwareExpressi
rule: DataFromReplacementRule)
extends BinaryExprMeta[A](expr, conf, parent, rule) {

var sparkFormat: String = _
var strfFormat: String = _
val optionalRightStringLit: Option[String] =
mythrocks marked this conversation as resolved.
Show resolved Hide resolved
if (expr.right.dataType == StringType) {
extractStringLit(expr.right)
} else {
None
}

lazy val (sparkFormat, strfFormat): (String, String) =
optionalRightStringLit match {
case Some(rightLit) =>
(rightLit,
DateUtils.tagAndGetCudfFormat(this, rightLit,
expr.left.dataType == DataTypes.StringType))
case None => (null, null)
}

override def tagExprForGpu(): Unit = {
// Date and Timestamp work too
if (expr.right.dataType == StringType) {
extractStringLit(expr.right) match {
case Some(rightLit) =>
sparkFormat = rightLit
strfFormat = DateUtils.tagAndGetCudfFormat(this,
sparkFormat, expr.left.dataType == DataTypes.StringType)
case None =>
willNotWorkOnGpu("format has to be a string literal")
}
if (expr.right.dataType == StringType && optionalRightStringLit.isEmpty) {
willNotWorkOnGpu("format has to be a string literal")
}
}
}
Expand Down