-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor automerge to support merge for protected branch #668
Conversation
build |
build |
3 similar comments
build |
build |
build |
Is that really the case? I find it very surprising that cudf's repo would leave the new development branch unprotected. Also my personal experience with cudf during auto-merge periods is that the new branch still requires CI checks and approvals before developers can merge to the branch, yet GPUtester can still merge the PRs without approval. |
yeah, they keep the CI check but added the |
Signed-off-by: Peixin Li <pxli@nyu.edu>
Signed-off-by: Peixin Li <pxli@nyu.edu>
4e086be
to
403a1c4
Compare
build |
build |
* support auto-merge on protected branch Signed-off-by: Peixin Li <pxli@nyu.edu>
* support auto-merge on protected branch Signed-off-by: Peixin Li <pxli@nyu.edu>
Previous auto-merge workflow only works for auto-merge into an unprotected branch, as how cudf's automerge does.
But this is not reasonable when we switch
branch-0.3
as default branch, so I added auto-approve for this automation workflow, and it will try approving auto-merged pr if possible.demo PR: pxLi#153
NOTE: a new secret
NVAUTO_TOKEN
has to be added to repo since github requires a different account to approve the PR.nvauto
is our automation account which has already been invited to spark-rapids repo.