-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code coverage to find source files in new places #723
Conversation
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
build |
Yup the code coverage is accurate, we just need to spend some time on making it better. The source files are now captured. |
I targeted this to 0.2, but it is minor and could easily be in 0.3 if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this going into 0.2 since it doesn't affect the main build but only the code coverage build and is arguably a bugfix.
So this PR didn't fix the problem right? I don't think it hurts to merge, just making sure i understand. I filed this one for the UDF compiler coverage issue: #728 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also make a change to https://github.com/NVIDIA/spark-rapids/blob/branch-0.2/jenkins/Jenkinsfile-blossom.premerge#L238? The old premerge pipeline will be retired after 0.2 release, so during this period we have do it in 2 places before we sunset the old one.
But I can make another PR if you want
@pxLi great catch. |
build |
build |
The base branch was changed.
build |
* Update code coverage to find source files in new places Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
* Update code coverage to find source files in new places Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
* Init 23.02.0 Signed-off-by: Peixin Li <pxli@nyu.edu> * target submodule to cudf branch-23.02 Signed-off-by: Peixin Li <pxli@nyu.edu>
I noticed that code coverage was not good for the UDF compiler, and that the source files were not being picked up either.
This hopefully fixes the later problem, for the former one I'm not sure if it was that the tests were not being picked up properly or if the coverage is really just not great. Once I know this works.