Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHANGELOG for release 0.2 #759

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Add CHANGELOG for release 0.2 #759

merged 3 commits into from
Sep 14, 2020

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Sep 14, 2020 •
edited
Loading

Signed-off-by: Peixin Li pxli@nyu.edu

According to the output there are a few PR w/o project info,
@sameerz @jlowe @revans2 @tgravescs Please help review the changelog

# Run w/ generate-changelog
GITHUB_TOKEN=xxx  scripts/generate-changelog --releases=0.2,0.1

# Output:
Generating changelog ...
Processing pull requests ...
Processing issues ...
Done.
Merged Pull Requests w/o Project:
branch-0.1 #181 Remove INCOMPAT for NormalizeNanAndZero, KnownFloatingPointNormalized https://github.com/NVIDIA/spark-rapids/pull/181
branch-0.1 #191 WindowExec handle different spark distributions https://github.com/NVIDIA/spark-rapids/pull/191
branch-0.1 #195 Support public release for plugin jar https://github.com/NVIDIA/spark-rapids/pull/195
branch-0.1 #206 Change groupID to 'com.nvidia' in IT scripts https://github.com/NVIDIA/spark-rapids/pull/206
branch-0.1 #208 Remove unneeded comment from pom.xml https://github.com/NVIDIA/spark-rapids/pull/208
branch-0.2 #645 [window] Add GpuWindowExec requiredChildOrdering https://github.com/NVIDIA/spark-rapids/pull/645
branch-0.2 #714 Move spark 3.0.1-shims out of snapshot-shims https://github.com/NVIDIA/spark-rapids/pull/714

FYI
image
To get a preview of the Markdown file

@pxLi pxLi added the documentation Improvements or additions to documentation label Sep 14, 2020
@jlowe
Copy link
Member

jlowe commented Sep 14, 2020

#645 and #714 were merged to branch-0.2 but did not have 0.2 set as a project and were missed from the changelog. It thought the changelog tool was supposed to report PRs merged without a project?

@jlowe
Copy link
Member

jlowe commented Sep 14, 2020

I've updated the project on those two PRs.

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 14, 2020 •
edited
Loading

#645 and #714 were merged to branch-0.2 but did not have 0.2 set as a project and were missed from the changelog. It thought the changelog tool was supposed to report PRs merged without a project?

Yes, it does not list PR w/o project in the generated File. And it reports the info in stdout for the tool user.

I will recommit a new one after #723 get merged

jlowe
jlowe reviewed Sep 14, 2020
View reviewed changes
CHANGELOG.md
|[#255](https://github.com/NVIDIA/spark-rapids/pull/255)|Revert change to make dependencies of shaded jar optional|
|[#257](https://github.com/NVIDIA/spark-rapids/pull/257)|Fix link to RAPIDS cudf in index.md|
|[#252](https://github.com/NVIDIA/spark-rapids/pull/252)|Update to 0.2.0-SNAPSHOT and cudf-0.15-SNAPSHOT|
## Release 0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add some whitespace before this line for those reading this as a regular text file.

jlowe
jlowe reviewed Sep 14, 2020
View reviewed changes
CHANGELOG.md
|[#74](https://github.com/NVIDIA/spark-rapids/issues/74)|[FEA] Support ToUnixTimestamp|
|[#21](https://github.com/NVIDIA/spark-rapids/issues/21)|[FEA] NormalizeNansAndZeros|
|[#105](https://github.com/NVIDIA/spark-rapids/issues/105)|[FEA] integration tests for equi-joins|
### Bugs Fixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly nice to have whitespace before these and other header lines when viewing as text.

@jlowe
Copy link
Member

jlowe commented Sep 14, 2020

#479 was not implemented, I marked it as wontfix. I also fixed typos in a number of issue/PR headlines.

#579 is an issue in the 0.2 release that is missing from the changelog. Please investigate how that was missed, there may be others missing as well. I'm guessing because it is missing the feature request, label, so I just added it to that one. However there may be others.

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 14, 2020

#479 was not implemented, I marked it as wontfix. I also fixed typos in a number of issue/PR headlines.

#579 is an issue in the 0.2 release that is missing from the changelog. Please investigate how that was missed, there may be others missing as well. I'm guessing because it is missing the feature request, label, so I just added it to that one. However there may be others.

Thx, #579 is added when I run script again

@sameerz
Copy link
Collaborator

sameerz commented Sep 14, 2020 •
edited
Loading

The PRs on branch-0.1 were part of the 0.1 release, I moved them to that project.

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 14, 2020

The PRs on branch-0.1 were part of the 0.1 release, I moved them to that project.

Thx, looks OK from local run. I will wait for #723 premerge run

@sameerz
Copy link
Collaborator

sameerz commented Sep 14, 2020

#723 is going to go into 0.3 (see the project update in the PR from two days ago). @revans2 can you retarget the PR to branch-0.3?

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 14, 2020 •
edited
Loading

#723 is going to go into 0.3 (see the project update in the PR from two days ago). @revans2 can you retarget the PR to branch-0.3?

kk, I just push a latest changelog file

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 14, 2020

build

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 14, 2020

build

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 14, 2020

@jlowe @sameerz Let me know if the latest changelog is OK or not, the release phase is blocked by this PR. thx!

sameerz
sameerz approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@sameerz sameerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

@pxLi pxLi merged commit 463eafe into NVIDIA:branch-0.2 Sep 14, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@pxLi
Add CHANGELOG for release 0.2 (NVIDIA#759)
93c2f38 
* Add CHANGELOG for release 0.2

Signed-off-by: Peixin Li <pxli@nyu.edu>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@pxLi
Add CHANGELOG for release 0.2 (NVIDIA#759)
6dd05c9 
* Add CHANGELOG for release 0.2

Signed-off-by: Peixin Li <pxli@nyu.edu>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
@nvauto
Update submodule cudf to a33e7fd7c65de333555b3b7901110bfb85bb365a (NV…
422db5a 
…IDIA#759)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe left review comments

@sameerz sameerz sameerz approved these changes

@GaryShen2008 GaryShen2008 GaryShen2008 approved these changes

@tgravescs tgravescs Awaiting requested review from tgravescs

@revans2 revans2 Awaiting requested review from revans2

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pxLi @jlowe @sameerz @GaryShen2008