Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in basic support for lead/lag #850

Merged
merged 6 commits into from
Oct 8, 2020
Merged

Add in basic support for lead/lag #850

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd5bf91
Add in support for lead/lag and fix a few window operations
revans2 Sep 24, 2020
865463d
Merge branch 'branch-0.3' into lead_lag
revans2 Oct 7, 2020
8370580
Merge branch 'branch-0.3' into lead_lag
revans2 Oct 8, 2020
ddc0181
Cleaned up comments and TODOs
revans2 Oct 8, 2020
49b6306
Addressed review comments
revans2 Oct 8, 2020
fbc0ff5
Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuWindowExp…
revans2 Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration_tests/src/main/python/window_function_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def do_it(spark):
.withColumn('row_num', f.row_number().over(baseWindowSpec))
assert_gpu_and_cpu_are_equal_collect(do_it, conf={'spark.rapids.sql.hasNans': 'false'})

# lead and lag don't currently work for strig columns, so redo the tests, but just for strings
# lead and lag don't currently work for string columns, so redo the tests, but just for strings
# without lead and lag
@ignore_order
@approximate_float
Expand Down
3 changes: 2 additions & 1 deletion sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuWindowExpression.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ class GpuWindowExpressionMeta(
willNotWorkOnGpu(s"Currently, only COUNT(1) and COUNT(*) are supported. " +
s"COUNT($exp) is not supported in windowing.")
}
// Sadly we have to white list the aggregations because they do not all work
// Sadly not all aggregations work for window operations yet, os explicitly allow the
revans2 marked this conversation as resolved.
Show resolved Hide resolved
// ones that do work.
case Count(_) | Sum(_) | Min(_) | Max(_) => // Supported.
case other: AggregateFunction =>
willNotWorkOnGpu(s"AggregateFunction ${other.prettyName} " +
Expand Down