Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in basic support for lead/lag #850

Merged
merged 6 commits into from
Oct 8, 2020
Merged

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Sep 24, 2020

This adds in support for lead and lag.

This fixes #81
This fixes #96

It partially addresses #216 but not enough to probably really matter beyond a few unit tests.

@revans2 revans2 self-assigned this Sep 24, 2020
@revans2 revans2 marked this pull request as draft September 24, 2020 21:16
@sameerz sameerz added the feature request New feature or request label Sep 25, 2020
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 marked this pull request as ready for review October 8, 2020 14:25
@revans2 revans2 changed the title [WIP] Add in basic support for lead/lag Add in basic support for lead/lag Oct 8, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Oct 8, 2020

build

Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Only a couple of comment nits, but note I'm not an expert on windowing.

…ression.scala

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@revans2
Copy link
Collaborator Author

revans2 commented Oct 8, 2020

Waiting for cudf 01.6 nightly to finish so the build will pass

@revans2
Copy link
Collaborator Author

revans2 commented Oct 8, 2020

build

@revans2
Copy link
Collaborator Author

revans2 commented Oct 8, 2020

build

@revans2 revans2 merged commit f36dd7b into NVIDIA:branch-0.3 Oct 8, 2020
@revans2 revans2 deleted the lead_lag branch October 8, 2020 21:22
sperlingxx pushed a commit to sperlingxx/spark-rapids that referenced this pull request Nov 20, 2020
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#850)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] window integration tests [FEA] Support Lag and Lead
3 participants