Re-enable from_json / JsonToStructs
#9423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
reviewed
Oct 12, 2023
andygrove
changed the title
from_json / JsonToStructsfrom_json / JsonToStructs
|
I am seeing two errors with the current code:
|
revans2
reviewed
Oct 31, 2023
| @@ -3556,17 +3556,19 @@ object GpuOverrides extends Logging { | |||
| expr[JsonToStructs]( | |||
| "Returns a struct value with the given `jsonStr` and `schema`", | |||
| ExprChecks.projectOnly( | |||
| TypeSig.MAP.nested(TypeSig.STRING).withPsNote(TypeEnum.MAP, | |||
| "MAP only supports keys and values that are of STRING type"), | |||
| TypeSig.STRUCT.nested(TypeSig.all) + | |||
There was a problem hiding this comment.
I don't think we really support all under a Struct. We don't support maps under a struct and we don't support UDTs under a struct. Could we be more explicit about what we do and do not support here?
andygrove
changed the title
from_json / JsonToStructsfrom_json / JsonToStructs
These issues are now resolved by recent bug fixes in cuDF |
revans2
approved these changes
Nov 6, 2023
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rapidsai/cudf#14309
This PR re-enables
from_json/JsonToStructs. It was previously disabled (see #8558) because it can cause incorrect results in some cases, but we have similar issues when reading directly from JSON files (see xfailed cases in #9304).Given that this expression does work correctly in many cases where the inputs are valid JSON, and that it is disabled by default, I would like to discuss adding this back in.