Support String type for AST #9672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Xu <ferdinandx@nvidia.com>
|
build |
1 similar comment
|
build |
winningsix
changed the title
winningsix
changed the title
revans2
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Just a nit that might be nice to have as a follow on issue. But I don't want this to go in until rapidsai/cudf#14397 is fixed or we risk possible data corruption.
| @@ -734,6 +734,7 @@ case class GpuLiteral (value: Any, dataType: DataType) extends GpuLeafExpression | |||
| case LongType => ast.Literal.ofLong(value.asInstanceOf[java.lang.Long]) | |||
| case FloatType => ast.Literal.ofFloat(value.asInstanceOf[java.lang.Float]) | |||
| case DoubleType => ast.Literal.ofDouble(value.asInstanceOf[java.lang.Double]) | |||
| case StringType => ast.Literal.ofString(value.asInstanceOf[UTF8String].toString) | |||
There was a problem hiding this comment.
I filed rapidsai/cudf#14397 related to this. It might be nice to have a follow on issue where we don't bother to go from UTF8String -> Java String (in UCS2) -> UTF8-byte array. We could just get the byte array from UTF8String and pass it directly to the Literal without any transcosing.
There was a problem hiding this comment.
Filed a PR addressing this in cudf side. rapidsai/cudf#14402
jlowe
approved these changes
Nov 15, 2023
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #8157
String type and literal are already included in cudf.
Test is covered by existing integration test.