Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support java AST String literal with desired encoding #14402

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

winningsix
Copy link
Contributor

@winningsix winningsix commented Nov 14, 2023

This fixes #14397 to allow different encoding for string literal.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Ferdinand Xu <ferdinandx@nvidia.com>
@winningsix winningsix requested a review from a team as a code owner November 14, 2023 09:44
Copy link

copy-pr-bot bot commented Nov 14, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Nov 14, 2023
@jlowe jlowe added bug Something isn't working non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS labels Nov 14, 2023
@jlowe
Copy link
Member

jlowe commented Nov 15, 2023

/ok to test

@revans2
Copy link
Contributor

revans2 commented Nov 15, 2023

/merge

@winningsix
Copy link
Contributor Author

winningsix commented Nov 15, 2023

It seems failed test cases are not related. We only changed Java binding part. Rebase to have a further try.

FAILED tests/test_dataframes.py::test_rolling_count_aggregations[dask-<lambda>-<lambda>0-5-3h-kwargs6-count] - RuntimeError: CUDA error encountered at: /opt/conda/conda-bld/work/cpp/include/cudf/detail/copy_range.cuh:182: 101 cudaErrorInvalidDevice invalid device ordinal
FAILED tests/test_dataframes.py::test_rolling_count_aggregations[dask-<lambda>-<lambda>0-5-window3-kwargs0-sum] - RuntimeError: CUDA error encountered at: /opt/conda/conda-bld/work/cpp/include/cudf/detail/copy_range.cuh:182: 101 cudaErrorInvalidDevice invalid device ordinal
FAILED tests/test_dataframes.py::test_rolling_count_aggregations[dask-<lambda>-<lambda>0-5-window3-kwargs1-mean] - RuntimeError: CUDA error encountered at: /opt/conda/conda-bld/work/cpp/include/cudf/detail/copy_range.cuh:182: 101 cudaErrorInvalidDevice invalid device ordinal
FAILED tests/test_dataframes.py::test_rolling_count_aggregations[dask-<lambda>-<lambda>0-5-window3-kwargs2-min] - RuntimeError: CUDA error encountered at: /opt/conda/conda-bld/work/cpp/include/cudf/detail/copy_range.cuh:182: 101 cudaErrorInvalidDevice invalid device ordinal
FAILED tests/test_dataframes.py::test_rolling_count_aggregations[dask-<lambda>-<lambda>0-5-window3-kwargs4-max] - RuntimeError: CUDA error encountered at: /opt/conda/conda-bld/work/cpp/include/cudf/detail/copy_range.cuh:182: 101 cudaErrorInvalidDevice invalid device ordinal
FAILED tests/test_dataframes.py::test_rolling_count_aggregations[dask-<lambda>-<lambda>0-5-window3-kwargs6-co

@ttnghia
Copy link
Contributor

ttnghia commented Nov 16, 2023

/ok to test

@rapids-bot rapids-bot bot merged commit f9c586d into rapidsai:branch-23.12 Nov 16, 2023
65 checks passed
@winningsix winningsix deleted the encode branch November 16, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] java AST String literal does not provide a desired encoding
4 participants