Pin to graphql-java 22.1, fix compilation errors #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override the graphql-java version from the Spring BOM to pull in 22.1, and fix the compilation errors caused by nullability annotations.
paulbakker
approved these changes
Jun 25, 2024
| // Use graphql-java 22.1, which is the version used by spring-graphql. Once | ||
| // the Spring Boot BOM depends on this version, we can remove this override. | ||
| // See: https://github.com/spring-projects/spring-boot/issues/41219 | ||
| extra["graphql-java.version"] = "22.1" |
There was a problem hiding this comment.
For future reference: I was surprised this works, since we don't reference this anywhere. However, it looks like the dependency recommender plugin from Spring Boot uses this to override versions.
srinivasankavitha
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override the graphql-java version from the Spring BOM to pull in 22.1, and fix the compilation errors caused by nullability annotations.