Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin to graphql-java 22.1, fix compilation errors #1945

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Pin to graphql-java 22.1, fix compilation errors #1945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ allprojects {
// as dependencies. e.g. KOTLIN_VERSION
extra["sb.version"] = "3.3.1"
extra["kotlin.version"] = Versions.KOTLIN_VERSION
// Use graphql-java 22.1, which is the version used by spring-graphql. Once
// the Spring Boot BOM depends on this version, we can remove this override.
// See: https://github.com/spring-projects/spring-boot/issues/41219
extra["graphql-java.version"] = "22.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference: I was surprised this works, since we don't reference this anywhere. However, it looks like the dependency recommender plugin from Spring Boot uses this to override versions.

}
val internalBomModules by extra(
listOf(
Expand Down
18 changes: 9 additions & 9 deletions graphql-dgs-client/dependencies.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions graphql-dgs-example-java-webflux/dependencies.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions graphql-dgs-example-java/dependencies.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions graphql-dgs-example-shared/dependencies.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions graphql-dgs-extended-scalars/dependencies.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading