Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LegacySimulateTransactions not returning correct error on reverte… #1535

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

omerfirmak
Copy link
Contributor

…d txns

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aa7f765) 72.81% compared to head (9587dba) 72.92%.

Files Patch % Lines
rpc/handlers.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
+ Coverage   72.81%   72.92%   +0.11%     
==========================================
  Files          96       96              
  Lines        9993     9997       +4     
==========================================
+ Hits         7276     7290      +14     
+ Misses       2174     2167       -7     
+ Partials      543      540       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wojciechos wojciechos merged commit 18319fd into main Dec 8, 2023
10 checks passed
@wojciechos wojciechos deleted the omerfirmak/fix-contract-err-sim-05 branch December 8, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants