Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LegacySimulateTransactions not returning correct error on reverte… #1535

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix LegacySimulateTransactions not returning correct error on reverte… #1535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rpc/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,7 +1407,11 @@
func (h *Handler) LegacySimulateTransactions(id BlockID, transactions []BroadcastedTransaction,
simulationFlags []SimulationFlag,
) ([]SimulatedTransaction, *jsonrpc.Error) {
return h.simulateTransactions(id, transactions, simulationFlags, true, false)
res, err := h.simulateTransactions(id, transactions, simulationFlags, true, true)
if err != nil && err.Code == ErrTransactionExecutionError.Code {
return nil, makeContractError(errors.New(err.Data.(TransactionExecutionErrorData).ExecutionError))
}
return res, err

Check warning on line 1414 in rpc/handlers.go

View check run for this annotation

Codecov / codecov/patch

rpc/handlers.go#L1414 

Added line #L1414 was not covered by tests
}

func (h *Handler) simulateTransactions(id BlockID, transactions []BroadcastedTransaction, //nolint: gocyclo
Expand Down
11 changes: 11 additions & 0 deletions rpc/handlers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3222,6 +3222,17 @@ func TestSimulateTransactions(t *testing.T) {
TransactionIndex: 44,
ExecutionError: "oops",
}), err)

mockVM.EXPECT().Execute(nil, nil, uint64(0), uint64(0), sequencerAddress, mockState, network, []*felt.Felt{}, false, true, true, nil, nil, true).
Return(nil, nil, vm.TransactionExecutionError{
Index: 44,
Cause: errors.New("oops"),
})

_, err = handler.LegacySimulateTransactions(rpc.BlockID{Latest: true}, []rpc.BroadcastedTransaction{}, []rpc.SimulationFlag{rpc.SkipValidateFlag})
require.Equal(t, rpc.ErrContractError.CloneWithData(rpc.ContractErrorData{
RevertError: "oops",
}), err)
})
}

Expand Down
Loading