-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split --disable-tests
, fix cross builds
#9611
Conversation
629f528
to
c8233da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about right, and seems to simplify the docs build logic, which I of course approve.
Please someone else review it properly.
c8233da
to
3660648
Compare
Discussed in Nix team meeting: Solution to "disable makefile" controversy is just inlining them to where they are used, the top-level |
3660648
to
1933877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good.
1933877
to
9237fc8
Compare
It might seem obnoxious to have yet more configure flags, but I found controlling both the unit and functional tests with one flag was quite confusing because they are so different: - unit tests depending on building, functional tests don't (e.g. when we test already-built Nix) - unit tests can be installed, functional tests cannot - unit tests neeed extra libraries (GTest, RapidCheck), functional tests need extra executables (jq). - unit tests are run by `make check`, functional tests are run by `make installcheck` Really on a technical level, they seem wholly independent. Only on a human level ("they are both are tests") do they have anything in common. I had messed up the logic in cross builds because of this. Now I split the flag in two (and cleaned up a few other inconsistencies), and the logic fixed itself. Co-Authored-By: Robert Hensing <roberth@users.noreply.github.com>
9237fc8
to
7feabf7
Compare
This fixed a CI failure (https://github.com/NixOS/nix/actions/runs/7204404968/job/19626137839, complaining about a failing @Ericson2314 can you take a look? |
#9646 Fixed here @thufschmitt . |
Motivation
It might seem obnoxious to have yet more configure flags, but I found controlling both the unit and functional tests with one flag was quite confusing because they are so different:
unit tests depending on building, functional tests don't (e.g. when we test already-built Nix)
unit tests can be installed, functional tests cannot
unit tests neeed extra libraries (GTest, RapidCheck), functional tests need extra executables (jq).
unit tests are run by
make check
, functional tests are run bymake installcheck
Really on a technical level, they seem wholly independent. Only on a human level ("they are both are tests") do they have anything in common.
I had messed up the logic in cross builds because of this. Now I split the flag in two (and cleaned up a few other inconsistencies), and the logic fixed itself.
Context
I broke cross builds in #9535
Priorities
Add 👍 to pull requests you find important.