Commits on Dec 18, 2023

1. Split --disable-tests, fix cross builds …

   It might seem obnoxious to have yet more configure flags, but I found
   controlling both the unit and functional tests with one flag was quite
   confusing because they are so different:
   
   - unit tests depending on building, functional tests don't (e.g. when
     we test already-built Nix)
   
   - unit tests can be installed, functional tests cannot
   
   - unit tests neeed extra libraries (GTest, RapidCheck), functional
     tests need extra executables (jq).
   
   - unit tests are run by `make check`, functional tests are run by `make
     installcheck`
   
   Really on a technical level, they seem wholly independent. Only on a
   human level ("they are both are tests") do they have anything in common.
   
   I had messed up the logic in cross builds because of this. Now I
   split the flag in two (and cleaned up a few other inconsistencies), and
   the logic fixed itself.
   
   Co-Authored-By: Robert Hensing <roberth@users.noreply.github.com>

   

   Ericson2314 and roberth committed Dec 18, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 7feabf7
   • Browse repository at this point

   Copy the full SHA

   7feabf7 View commit details

   Browse the repository at this point in the history