xandikos: backport systemd socket activation #161690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a little bit baffled about your PR description and the actual changes. |
|
Yeah, you're right. Xandikos was always able to do that, this PR just adds that to the nginx configuration. |
|
Topic and changes fit together. But I mean the mismatching description: |
|
Yeah, I think you are right, when I made this I still had xandikos-0.2.6 and was about to create a pull request for that too but noticed this and probably mixed up the pull requests. |
0x4A6F
requested changes
Mar 2, 2022
|
While writing a test I noticed that the permission of the socket are too strict to be useful. Changing the services UMask does not seem appropriate. We should probably put this off until systemd's socket activation makes it into xandikos, see jelmer/xandikos#155. |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
labels
schnusch
changed the title
schnusch
force-pushed
the
xandikos
branch
2 times, most recently
from
38f15b8
to
bce1a19
Compare
stale
bot
added
the
2.status: stale
This way systemd takes care of the owner and the permissions of the socket.
|
Rebased to fix merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backported jelmer/xandikos#155 to add support for systemd socket activation. This also enables UNIX sockets with proper owner/permissions, because systemd creates them for us.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes