nixos/xandikos: use systemd socket activation #253634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
schnusch
force-pushed
the
nixos/xandikos
branch
4 times, most recently
from
3fb8524
to
53e0f99
Compare
|
Rebased onto #253612. |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
wegank
added
the
2.status: stale
schnusch
force-pushed
the
nixos/xandikos
branch
from
53e0f99
to
456fd05
Compare
stale
bot
removed
the
2.status: stale
Xandikos' handling of listening addresses is quite buggy. There were multiple bugs regarding socket activation, which caused it to also listen on unwanted default ports. Additionally the metrics port reuses the listen address. To avoid all this unexpected behaviour we run Xandikos in a private network namespace and let systemd handle our *wanted* listening adresses. Optionally the metrics are made accessible in the host's network namespace through `xandikos-metrics.service` using systemd-socket-proxyd.
schnusch
force-pushed
the
nixos/xandikos
branch
from
456fd05
to
d34e556
Compare
ofborg
bot
added
10.rebuild-linux: 11-100
and removed
2.status: merge conflict
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Xandikos' handling of listening addresses is quite buggy. There were multiple bugs regarding socket activation, which caused it to also listen on unwanted default ports. Additionally the metrics port reuses the listen address.
To avoid all this unexpected behaviour we run Xandikos in a private network namespace and let systemd handle our wanted listening adresses. Optionally the metrics are made accessible in the host's network namespace through
xandikos-metrics.serviceusing systemd-socket-proxyd.Depends on #253612.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)