Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.05] python3Packages.nbconvert: use mistune 2.x #187839

Closed
wants to merge 4 commits into from
Closed

[22.05] python3Packages.nbconvert: use mistune 2.x #187839

wants to merge 4 commits into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 22, 2022 •
edited
Loading

Description of changes

Backport of #187151, #186804 to get opsdroid on 22.05 buildable again.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

smancill and others added 3 commits August 22, 2022 11:05
@smancill @Ma27
python310Packages.nbconvert: use mistune 2.x
4526204 
mistune 0.8 was removed by NixOS#186272.

(cherry picked from commit 8d05ef5)
(cherry picked from commit 898d644)
@onny @Ma27
python310Packages.nbconvert: 6.5.0 -> 6.5.3
5a182a0 
(cherry picked from commit 2ee664d)
(cherry picked from commit c5c7857)
@Ma27
python3Packages.nbconvert: actually switch to mistune2
32e0e57 
This change is also needed on stable because `mistune` points to
`mistune_0_8` rather than `mistune_2_0`.

(cherry picked from commit 44e9fe8)
@Ma27 Ma27 requested a review from globin August 22, 2022 09:17
FRidh
FRidh requested changes Aug 22, 2022
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in different versions of mistune used within the python packages set. That's not acceptable.

#187550 (comment)

@Ma27
python3: make mistune2 the new default and mark failing builds as broken
6d2066a 
Not a big loss because these would evaluate anyways before.
@Ma27
Copy link
Member Author

Ma27 commented Aug 23, 2022

Can be closed now considering #188031.

@Ma27 Ma27 closed this Aug 23, 2022
@Ma27 Ma27 deleted the backport-nbconvert-fixes branch August 23, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@jonringer jonringer Awaiting requested review from jonringer

@veprbl veprbl Awaiting requested review from veprbl

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@costrouc costrouc Awaiting requested review from costrouc

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ma27 @FRidh @smancill @onny