Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqPackages.mathcomp: 1 -> 2 #331530

Merged
merged 2 commits into from
Aug 20, 2024
Merged

coqPackages.mathcomp: 1 -> 2 #331530

merged 2 commits into from
Aug 20, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Aug 1, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@proux01
Copy link
Contributor Author

proux01 commented Aug 1, 2024

@vbgl successfully tested on coq-community/coq-nix-toolbox#241

This make mathcomp 2 the default, now that most user did switch to it, it's probably more convenient for everyone.

@CohenCyril
Copy link
Contributor

@vbgl merge?

@h7x4 h7x4 merged commit 574f430 into NixOS:master Aug 20, 2024
29 checks passed
@proux01 proux01 deleted the mc2-default branch August 20, 2024 06:54
proux01 added a commit to proux01/coq-nix-toolbox that referenced this pull request Aug 20, 2024
@proux01
Copy link
Contributor Author

proux01 commented Aug 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants