Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mathcomp: 1 -> 2 #241

Merged
merged 1 commit into from
Aug 20, 2024
Merged

mathcomp: 1 -> 2 #241

merged 1 commit into from
Aug 20, 2024

Conversation

proux01
Copy link
Collaborator

@proux01 proux01 commented Jul 31, 2024

Diff is not very readable so here is a sumup of the change in packages that are available with default mathcomp

8.16
- coq-bits
- coqeal
- deriving
- extructures
- gaia
- gaia-hydras
- mathcomp-analysis
- mathcomp-apery
- mathcomp-classical
- mathcomp-infotheo
- multinomials

=> let's keep MC1 the default on Coq 8.16

8.17
+ mathcomp-tarjan

8.18
+ mathcomp-tarjan
+ ssprove

8.19
+ coqeal
+ gaia
+ graph-theory
+ mathcomp-tarjan
+ ssprove

8.20
+ coqeal
+ gaia
+ mathcomp-algebra-tactics
+ mathcomp-analysis
+ mathcomp-classical
+ mathcomp-real-closed
+ mathcomp-tarjan

@proux01 proux01 force-pushed the mc2-default branch 2 times, most recently from 6282270 to 1d762f6 Compare August 1, 2024 13:25
@CohenCyril
Copy link
Collaborator

@proux01 Given the losses for 8.16, I would advocate keeping mathcomp 1 as default there. As for 8.17 it's on par, but out of sentimentality I would be inclined to keep mathcomp 1 so that gaia still compiles there. From 8.18 on I am in favor of switching to mathcomp 2.

@CohenCyril
Copy link
Collaborator

Thanks for making the experiments.

@proux01
Copy link
Collaborator Author

proux01 commented Aug 1, 2024

Makes a lot of sense. About gaia, it appears that we just never updated the Nix package with the newer release on MathComp 2, then let's switch to MC2 starting at Coq 8.17 since it's a net gain from there.

@CohenCyril
Copy link
Collaborator

Makes a lot of sense. About gaia, it appears that we just never updated the Nix package with the newer release on MathComp 2, then let's switch to MC2 starting at Coq 8.17 since it's a net gain from there.

Ah perfect! Well done

@proux01
Copy link
Collaborator Author

proux01 commented Aug 2, 2024

So CI seems happy and confirms that we don't remove any package

@proux01 proux01 marked this pull request as ready for review August 20, 2024 12:08
@proux01 proux01 merged commit 99e1b96 into coq-community:master Aug 20, 2024
1138 of 1142 checks passed
@proux01 proux01 deleted the mc2-default branch August 20, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants