Support older hard forks #1372
Merged
Support older hard forks #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcuadrado
commented
Apr 6, 2021
| @@ -188,6 +196,40 @@ export class HardhatNode extends EventEmitter { | |||
| return [common, node]; | |||
| } | |||
|
|
|||
| private static _validateHardforks( | |||
There was a problem hiding this comment.
We validate this here because:
- The config validation can't make requests and fetch the remote chainId.
- The
nodetask can provide a different block number so the config validation won't be enough.
alcuadrado
commented
Apr 6, 2021
| remoteChainId: number | ||
| ): void { | ||
| if (!common.gteHardfork("spuriousDragon")) { | ||
| throw new InternalError( |
There was a problem hiding this comment.
Throwing ProviderErrors because this are thrown from a request, as the HardhatNode instance is created on the first RPC request.
alcuadrado
commented
Apr 6, 2021
| @@ -4506,3 +4508,47 @@ describe("Eth module", function () { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("Eth module - special tests", function () { | |||
There was a problem hiding this comment.
Created this other tests as they depend on fixture projects, and not the PROVIDERS array.
fvictorio
reviewed
Apr 6, 2021
packages/hardhat-core/src/internal/hardhat-network/provider/node.ts
Outdated
Show resolved
Hide resolved
packages/hardhat-core/src/internal/hardhat-network/provider/node.ts
Outdated
Show resolved
Hide resolved
packages/hardhat-core/test/internal/hardhat-network/provider/hardhat-network-options.ts
Outdated
Show resolved
Hide resolved
packages/hardhat-core/test/internal/hardhat-network/provider/hardhat-network-options.ts
Outdated
Show resolved
Hide resolved
…ardhat-network-options.ts Co-authored-by: Franco Victorio <victorio.franco@gmail.com>
…de.ts Co-authored-by: Franco Victorio <victorio.franco@gmail.com>
…ation-issue Workaround transactions recreation issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.