Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support older hard forks #1372

Merged
merged 15 commits into from
Apr 6, 2021
Merged

Support older hard forks #1372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c3e7887
Update the list of supported hardforks
alcuadrado Apr 5, 2021
c6de2c4
Validate both local and remote HF
alcuadrado Apr 5, 2021
96224b6
Correctly format pre/post byzantium receipts
alcuadrado Apr 5, 2021
8d9b716
Test hardhat network's HF validation
alcuadrado Apr 5, 2021
362ebf8
Test the pre/post Byzantium receipt formatting
alcuadrado Apr 5, 2021
cccd5be
Fix linting error
alcuadrado Apr 6, 2021
d2248e9
Update packages/hardhat-core/test/internal/hardhat-network/provider/h…
alcuadrado Apr 6, 2021
61a3625
Update packages/hardhat-core/src/internal/hardhat-network/provider/no…
alcuadrado Apr 6, 2021
d6a49d3
Add a comment explaining a failure to validate the commons
alcuadrado Apr 6, 2021
889d219
Address review comments
alcuadrado Apr 6, 2021
173b76a
Imprve the hardhat_impersonateAccount test
alcuadrado Apr 6, 2021
af18363
Workaround an issue due to Block recreating all the txs
alcuadrado Apr 6, 2021
f773156
Style fix
alcuadrado Apr 6, 2021
e214e25
Remove brokin unused import
alcuadrado Apr 6, 2021
644259a
Merge pull request #1377 from nomiclabs/workaround-transactions-recre…
fvictorio Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments
  • Loading branch information
@alcuadrado
alcuadrado committed Apr 6, 2021
commit 889d219506d3cf7c77ccd82d0f28f99c32847537
4 changes: 1 addition & 3 deletions packages/hardhat-core/src/internal/hardhat-network/provider/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ export class HardhatNode extends EventEmitter {
common = await makeForkCommon(config);

this._validateHardforks(
config.hardfork,
config.forkConfig.blockNumber,
common,
forkClient.getNetworkId()
Expand Down Expand Up @@ -197,7 +196,6 @@ export class HardhatNode extends EventEmitter {
}

private static _validateHardforks(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We validate this here because:

  1. The config validation can't make requests and fetch the remote chainId.
  2. The node task can provide a different block number so the config validation won't be enough.

localHardfork: string,
forkBlockNumber: number | undefined,
common: Common,
remoteChainId: number
Expand All @@ -206,7 +204,7 @@ export class HardhatNode extends EventEmitter {
throw new InternalError(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing ProviderErrors because this are thrown from a request, as the HardhatNode instance is created on the first RPC request.

`Invalid hardfork selected in Hardhat Network's config.

The hardfork must be at least spuriousDragon, but ${localHardfork} was given.`
The hardfork must be at least spuriousDragon, but ${common.hardfork()} was given.`
);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/hardhat-core/test/internal/hardhat-network/provider/hardhat-network-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ describe("Hardhat Network special options", function () {
useFixtureProject("hardhat-network-spurious-dragon");
useEnvironment();

it("should accept hard forks as late as chainnstart and use them", async function () {
it("should accept hardforks as late as chainstart and use them", async function () {
const [sender] = await this.env.network.provider.send("eth_accounts");
await assert.isRejected(
this.env.network.provider.send("eth_sendTransaction", [
Expand Down